inpt/ponytracker
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

avoid useless retrieval of user object

Browse source
This commit is contained in:
Élie Bouttier 2014-08-07 13:54:09 -07:00
parent 4c7e906c1a
commit fbdc2c1aca
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
issue/views.py
View file

@ -144,14 +144,12 @@ def issue_list(request, project):
issues = issues.filter(milestone=milestone) issues = issues.filter(milestone=milestone)
elif key == 'author' or key == 'user': elif key == 'author' or key == 'user':
try: if User.objects.filter(username=value).exists():
author = User.objects.get(username=value) issues = issues.filter(author__username=value)
except ObjectDoesNotExist: else:
messages.error(request, "The user '%s' does not exist." %value) messages.error(request, "The user '%s' does not exist." %value)
issues = None issues = None
break break
else:
issues = issues.filter(author=author)
else: else:
messages.error(request, "Unknow '%s' filtering criterion." %key) messages.error(request, "Unknow '%s' filtering criterion." %key)