inpt/ponytracker
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

replace .count() by .exists() in condition

Browse source
This commit is contained in:
Élie Bouttier 2014-08-06 00:06:54 -07:00
parent dfec0f0ee9
commit 89b2751448
2 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
issue/models.py
View file

@ -135,13 +135,13 @@ class Issue(models.Model):
def getdesc(self): def getdesc(self):
desc = self.events.filter(issue=self,code=Event.DESCRIBE) desc = self.events.filter(issue=self,code=Event.DESCRIBE)
if desc.count(): if desc.exists():
return desc.first().additionnal_section return desc.first().additionnal_section
else: else:
return None return None
def setdesc(self, value): def setdesc(self, value):
desc = self.events.filter(issue=self,code=Event.DESCRIBE) desc = self.events.filter(issue=self,code=Event.DESCRIBE)
if desc.count(): if desc.exists():
desc = desc.first() desc = desc.first()
desc.additionnal_section = value desc.additionnal_section = value
desc.save() desc.save()
@ -151,7 +151,7 @@ class Issue(models.Model):
desc.save() desc.save()
def deldesc(self): def deldesc(self):
desc = self.events.filter(issue=self,code=Event.DESCRIBE) desc = self.events.filter(issue=self,code=Event.DESCRIBE)
if desc.count(): if desc.exists():
desc.first().delete() desc.first().delete()
description = property(getdesc, setdesc, deldesc) description = property(getdesc, setdesc, deldesc)

8
issue/views.py
View file

@ -29,7 +29,7 @@ def project_add(request):
if Project.objects \ if Project.objects \
.filter(display_name__iexact=form.cleaned_data['display_name']) \ .filter(display_name__iexact=form.cleaned_data['display_name']) \
.count(): .exists():
form._errors['display_name'] = ['There is already a project with a similar name.'] form._errors['display_name'] = ['There is already a project with a similar name.']
@ -57,7 +57,7 @@ def project_edit(request, project):
if Project.objects \ if Project.objects \
.filter(display_name__iexact=form.cleaned_data['display_name']) \ .filter(display_name__iexact=form.cleaned_data['display_name']) \
.exclude(pk=project.pk).count(): .exclude(pk=project.pk).exists():
form._errors['display_name'] = ['There is already a project with a similar name.'] form._errors['display_name'] = ['There is already a project with a similar name.']
@ -422,7 +422,7 @@ def label_edit(request, project, id=None):
if label: if label:
similar = similar.exclude(pk=label.pk) similar = similar.exclude(pk=label.pk)
if similar.count(): if similar.exists():
form._errors['name'] = ['There is already a label with this name.'] form._errors['name'] = ['There is already a label with this name.']
@ -507,7 +507,7 @@ def milestone_edit(request, project, name=None):
if milestone: if milestone:
similar = similar.exclude(pk=milestone.pk) similar = similar.exclude(pk=milestone.pk)
if similar.count(): if similar.exists():
form._errors['name'] = ['There is already a milestone with this name.'] form._errors['name'] = ['There is already a milestone with this name.']