This commit is contained in:
Élie Bouttier 2014-08-09 01:13:42 -07:00
parent fde1c147c9
commit 3a211b74a4
13 changed files with 238 additions and 146 deletions

View file

@ -5,10 +5,11 @@ from issue.models import *
def user_has_perm(user, perm, perms): def user_has_perm(user, perm, perms):
for p in perms: for p in perms:
# this permission allow that action and the user is concerned by this permission # this perm allow that action and the user is concerned by this perm
if hasattr(p, perm) and getattr(p, perm) and p.granted_to(user): if hasattr(p, perm) and getattr(p, perm) and p.granted_to(user):
return True return True
class ProjectBackend(ModelBackend): class ProjectBackend(ModelBackend):
def has_perm(self, user, perm, obj=None): def has_perm(self, user, perm, obj=None):

View file

@ -15,6 +15,7 @@ class PermissionChecker:
if request.user.is_authenticated(): if request.user.is_authenticated():
return request.user.has_perm(perm, obj) return request.user.has_perm(perm, obj)
class PermWrapper: class PermWrapper:
def __init__(self, user): def __init__(self, user):
@ -29,10 +30,7 @@ class PermWrapper:
def __contains__(self, perm): def __contains__(self, perm):
return self[perm] return self[perm]
def can_user(request): def can_user(request):
wrapper = PermWrapper(request.user) wrapper = PermWrapper(request.user)
return {'can_user': wrapper}
return {
'can_user': wrapper,
}

View file

@ -6,9 +6,14 @@ from django_markdown.widgets import MarkdownWidget
from issue.models import * from issue.models import *
AddProjectForm = modelform_factory(Project, fields=['display_name', 'name', 'description', 'public'])
EditProjectForm = modelform_factory(Project, fields=['display_name', 'description', 'public']) AddProjectForm = modelform_factory(Project,
LabelForm = modelform_factory(Label, fields=['name', 'color', 'inverted']) fields=['display_name', 'name', 'description', 'public'])
EditProjectForm = modelform_factory(Project,
fields=['display_name', 'description', 'public'])
LabelForm = modelform_factory(Label,
fields=['name', 'color', 'inverted'])
class MilestoneForm(forms.ModelForm): class MilestoneForm(forms.ModelForm):
@ -19,13 +24,16 @@ class MilestoneForm(forms.ModelForm):
'due_date': DateTimePicker(format="YYYY-MM-DD HH:mm"), 'due_date': DateTimePicker(format="YYYY-MM-DD HH:mm"),
} }
class IssueForm(forms.Form): class IssueForm(forms.Form):
title = forms.CharField(max_length=128) title = forms.CharField(max_length=128)
description = forms.CharField(widget=MarkdownWidget, required=False) description = forms.CharField(widget=MarkdownWidget, required=False)
class CommentForm(forms.Form): class CommentForm(forms.Form):
comment = forms.CharField(widget=MarkdownWidget) comment = forms.CharField(widget=MarkdownWidget)
class PermissionForm(forms.ModelForm): class PermissionForm(forms.ModelForm):
class Meta: class Meta:
@ -37,7 +45,7 @@ class PermissionForm(forms.ModelForm):
data = super(PermissionForm, self).clean() data = super(PermissionForm, self).clean()
if not 'grantee_name' in data or not 'grantee_type' in data: if 'grantee_name' not in data or 'grantee_type' not in data:
# a field required error will be printed so we dont care # a field required error will be printed so we dont care
return data return data
@ -45,22 +53,24 @@ class PermissionForm(forms.ModelForm):
if int(data['grantee_type']) == PermissionModel.GRANTEE_USER: if int(data['grantee_type']) == PermissionModel.GRANTEE_USER:
if not User.objects.filter(username=name).exists(): if not User.objects.filter(username=name).exists():
raise ValidationError("User '%s' does not exists." %name) raise ValidationError("User '%s' does not exists." % name)
elif int(data['grantee_type']) == PermissionModel.GRANTEE_GROUP: elif int(data['grantee_type']) == PermissionModel.GRANTEE_GROUP:
if not Group.objects.filter(name=name).exists(): if not Group.objects.filter(name=name).exists():
raise ValidationError("Group '%s' does not exists." %name) raise ValidationError("Group '%s' does not exists." % name)
elif int(data['grantee_type']) == PermissionModel.GRANTEE_TEAM: elif int(data['grantee_type']) == PermissionModel.GRANTEE_TEAM:
if not Team.objects.filter(name=name).exists(): if not Team.objects.filter(name=name).exists():
raise ValidationError("Team '%s' does not exists." %name) raise ValidationError("Team '%s' does not exists." % name)
return data return data
class GlobalPermissionForm(PermissionForm): class GlobalPermissionForm(PermissionForm):
class Meta: class Meta:
model = GlobalPermission model = GlobalPermission
exclude = [] exclude = []
class ProjectPermissionForm(PermissionForm): class ProjectPermissionForm(PermissionForm):
class Meta: class Meta:

View file

@ -5,6 +5,7 @@ from django.contrib.auth.decorators import login_required
from django.db.models import Q from django.db.models import Q
from issue.models import * from issue.models import *
from issue.models import PermissionModel as PermModel
class ProjectMiddleware: class ProjectMiddleware:
@ -35,13 +36,15 @@ class ProjectMiddleware:
query = Q(public=True) query = Q(public=True)
if user: if user:
# access granted through a team # access granted through a team
query |= Q(permissions__grantee_type=PermissionModel.GRANTEE_TEAM, teams = user.teams.values_list('name')
permissions__grantee_name__in=user.teams.values_list('name')) query |= Q(permissions__grantee_type=PermModel.GRANTEE_TEAM,
permissions__grantee_name__in=teams)
# access granted through a group # access granted through a group
query |= Q(permissions__grantee_type=PermissionModel.GRANTEE_GROUP, groups = user.groups.values_list('name')
permissions__grantee_name__in=user.groups.values_list('name')) query |= Q(permissions__grantee_type=PermModel.GRANTEE_GROUP,
permissions__grantee_name__in=groups)
# access granted by specific permission # access granted by specific permission
query |= Q(permissions__grantee_type=PermissionModel.GRANTEE_USER, query |= Q(permissions__grantee_type=PermModel.GRANTEE_USER,
permissions__grantee_name=user.username) permissions__grantee_name=user.username)
projects = Project.objects.filter(query).distinct() projects = Project.objects.filter(query).distinct()
request.projects = projects request.projects = projects

View file

@ -25,7 +25,9 @@ class User(auth.models.User):
@property @property
def teams(self): def teams(self):
return Team.objects.filter(Q(groups__in=self.groups.all()) | Q(users=self)) query = Q(groups__in=self.groups.all()) | Q(users=self)
return Team.objects.filter(query)
class Project(models.Model): class Project(models.Model):
@ -44,12 +46,14 @@ class Project(models.Model):
verbose_name="Description") verbose_name="Description")
public = models.BooleanField(default=True, public = models.BooleanField(default=True,
verbose_name="Do unregistered users have read access to this project?") verbose_name="Do unregistered users have read access "
"to this project?")
def __str__(self): def __str__(self):
return self.display_name return self.display_name
class Label(models.Model): class Label(models.Model):
project = models.ForeignKey(Project, related_name='labels') project = models.ForeignKey(Project, related_name='labels')
@ -58,9 +62,11 @@ class Label(models.Model):
deleted = models.BooleanField(default=False) deleted = models.BooleanField(default=False)
color = RGBColorField(default='#000000', verbose_name="Background color") color = RGBColorField(default='#000000',
verbose_name="Background color")
inverted = models.BooleanField(default=True, verbose_name="Inverse text color") inverted = models.BooleanField(default=True,
verbose_name="Inverse text color")
@property @property
def quotted_name(self): def quotted_name(self):
@ -73,6 +79,7 @@ class Label(models.Model):
def __str__(self): def __str__(self):
return self.name return self.name
class Milestone(models.Model): class Milestone(models.Model):
name_validator = RegexValidator(regex='^[a-z0-9_.-]+$', name_validator = RegexValidator(regex='^[a-z0-9_.-]+$',
@ -84,9 +91,9 @@ class Milestone(models.Model):
name = models.CharField(max_length=32, validators=[name_validator]) name = models.CharField(max_length=32, validators=[name_validator])
class Meta: class Meta:
unique_together = [ 'project', 'name' ] unique_together = ['project', 'name']
due_date = models.DateTimeField(blank=True,null=True) due_date = models.DateTimeField(blank=True, null=True)
closed = models.BooleanField(default=False) closed = models.BooleanField(default=False)
@ -104,13 +111,14 @@ class Milestone(models.Model):
total = self.total_issues() total = self.total_issues()
if total: if total:
return int(100 * closed / total); return int(100 * closed / total)
else: else:
return 0 return 0
def __str__(self): def __str__(self):
return self.name return self.name
class Issue(models.Model): class Issue(models.Model):
global_id = models.AutoField(primary_key=True) global_id = models.AutoField(primary_key=True)
@ -119,7 +127,7 @@ class Issue(models.Model):
id = models.IntegerField(editable=False) id = models.IntegerField(editable=False)
class Meta: class Meta:
unique_together = [ 'project', 'id' ] unique_together = ['project', 'id']
title = models.CharField(max_length=128) title = models.CharField(max_length=128)
@ -129,9 +137,11 @@ class Issue(models.Model):
closed = models.BooleanField(default=False) closed = models.BooleanField(default=False)
labels = models.ManyToManyField(Label, blank=True, null=True, related_name='issues') labels = models.ManyToManyField(Label, blank=True, null=True,
related_name='issues')
milestone = models.ForeignKey(Milestone, blank=True, null=True, related_name='issues') milestone = models.ForeignKey(Milestone, blank=True, null=True,
related_name='issues')
assignee = models.ForeignKey(User, blank=True, null=True, related_name='+') assignee = models.ForeignKey(User, blank=True, null=True, related_name='+')
@ -146,18 +156,19 @@ class Issue(models.Model):
def comments(self): def comments(self):
comments = self.events.filter(issue=self,code=Event.COMMENT) comments = self.events.filter(issue=self, code=Event.COMMENT)
return comments return comments
def getdesc(self): def getdesc(self):
desc = self.events.filter(issue=self,code=Event.DESCRIBE) desc = self.events.filter(issue=self, code=Event.DESCRIBE)
if desc.exists(): if desc.exists():
return desc.first().additionnal_section return desc.first().additionnal_section
else: else:
return None return None
def setdesc(self, value): def setdesc(self, value):
desc = self.events.filter(issue=self,code=Event.DESCRIBE) desc = self.events.filter(issue=self, code=Event.DESCRIBE)
if desc.exists(): if desc.exists():
desc = desc.first() desc = desc.first()
desc.additionnal_section = value desc.additionnal_section = value
@ -166,8 +177,9 @@ class Issue(models.Model):
desc = Event(issue=self, author=self.author, code=Event.DESCRIBE, desc = Event(issue=self, author=self.author, code=Event.DESCRIBE,
additionnal_section=value) additionnal_section=value)
desc.save() desc.save()
def deldesc(self): def deldesc(self):
desc = self.events.filter(issue=self,code=Event.DESCRIBE) desc = self.events.filter(issue=self, code=Event.DESCRIBE)
if desc.exists(): if desc.exists():
desc.first().delete() desc.first().delete()
description = property(getdesc, setdesc, deldesc) description = property(getdesc, setdesc, deldesc)
@ -194,12 +206,14 @@ class Issue(models.Model):
if self.milestone == milestone: if self.milestone == milestone:
return return
if self.milestone: if self.milestone:
event = Event(issue=self, author=author, code=Event.CHANGE_MILESTONE, event = Event(issue=self, author=author,
code=Event.CHANGE_MILESTONE,
args={'old_milestone': self.milestone.name, args={'old_milestone': self.milestone.name,
'new_milestone': milestone.name}) 'new_milestone': milestone.name})
event.save() event.save()
else: else:
event = Event(issue=self, author=author, code=Event.SET_MILESTONE, event = Event(issue=self, author=author,
code=Event.SET_MILESTONE,
args={'milestone': milestone.name}) args={'milestone': milestone.name})
event.save() event.save()
self.milestone = milestone self.milestone = milestone
@ -210,13 +224,15 @@ class Issue(models.Model):
self.milestone = None self.milestone = None
if commit: if commit:
self.save() self.save()
event = Event(issue=self, author=author, code=Event.UNSET_MILESTONE, event = Event(issue=self, author=author,
code=Event.UNSET_MILESTONE,
args={'milestone': milestone.name}) args={'milestone': milestone.name})
event.save() event.save()
def __str__(self): def __str__(self):
return self.title return self.title
@python_2_unicode_compatible @python_2_unicode_compatible
class Event(models.Model): class Event(models.Model):
@ -247,8 +263,10 @@ class Event(models.Model):
def getargs(self): def getargs(self):
return json.loads(self._args) return json.loads(self._args)
def setargs(self, args): def setargs(self, args):
self._args = json.dumps(args) self._args = json.dumps(args)
def delargs(self): def delargs(self):
self._args = "{}" self._args = "{}"
args = property(getargs, setargs, delargs) args = property(getargs, setargs, delargs)
@ -297,18 +315,21 @@ class Event(models.Model):
elif self.code == Event.REOPEN: elif self.code == Event.REOPEN:
description = "reopened this issue" description = "reopened this issue"
elif self.code == Event.RENAME: elif self.code == Event.RENAME:
description = "changed the title from <mark>{old_title}</mark> to <mark>{new_title}</mark>" description = "changed the title from <mark>{old_title}</mark> " \
"to <mark>{new_title}</mark>"
elif self.code == Event.ADD_LABEL or self.code == Event.DEL_LABEL: elif self.code == Event.ADD_LABEL or self.code == Event.DEL_LABEL:
label = Label.objects.get(id=args['label']) label = Label.objects.get(id=args['label'])
if self.code == Event.ADD_LABEL: if self.code == Event.ADD_LABEL:
action = 'added' action = 'added'
else: else:
action = 'removed' action = 'removed'
description = '%s the <a href="%s">%s</a> label' %(action, same_label(label), labeled(label)) description = '%s the <a href="%s">%s</a> label' \
% (action, same_label(label), labeled(label))
elif self.code == Event.SET_MILESTONE: elif self.code == Event.SET_MILESTONE:
description = "added this to the {milestone} milestone" description = "added this to the {milestone} milestone"
elif self.code == Event.CHANGE_MILESTONE: elif self.code == Event.CHANGE_MILESTONE:
description = "moved this from the {old_milestone} milestone to the {new_milestone} milestone" description = "moved this from the {old_milestone} milestone " \
"to the {new_milestone} milestone"
elif self.code == Event.UNSET_MILESTONE: elif self.code == Event.UNSET_MILESTONE:
description = "deleted this from the {milestone} milestone" description = "deleted this from the {milestone} milestone"
elif self.code == Event.REFERENCE: elif self.code == Event.REFERENCE:
@ -321,6 +342,7 @@ class Event(models.Model):
return mark_safe(description.format(**safe_args)) return mark_safe(description.format(**safe_args))
class Settings(models.Model): class Settings(models.Model):
site = models.OneToOneField(Site) site = models.OneToOneField(Site)
@ -328,16 +350,20 @@ class Settings(models.Model):
class Meta: class Meta:
verbose_name_plural = 'Settings' verbose_name_plural = 'Settings'
class Team(models.Model): class Team(models.Model):
name = models.CharField(max_length=128, unique=True) name = models.CharField(max_length=128, unique=True)
users = models.ManyToManyField(auth.models.User, blank=True, null=True, related_name='teams') users = models.ManyToManyField(auth.models.User, blank=True, null=True,
groups = models.ManyToManyField(auth.models.Group, blank=True, null=True, related_name='teams') related_name='teams')
groups = models.ManyToManyField(auth.models.Group, blank=True, null=True,
related_name='teams')
def __str__(self): def __str__(self):
return self.name return self.name
class PermissionModel(models.Model): class PermissionModel(models.Model):
GRANTEE_USER = 0 GRANTEE_USER = 0
@ -378,6 +404,7 @@ class PermissionModel(models.Model):
def __str__(self): def __str__(self):
return self.grantee_name return self.grantee_name
class GlobalPermission(PermissionModel): class GlobalPermission(PermissionModel):
create_project = models.BooleanField(default=True) create_project = models.BooleanField(default=True)
@ -392,9 +419,11 @@ class GlobalPermission(PermissionModel):
def __str__(self): def __str__(self):
return self.grantee_name + "'s global permissions" return self.grantee_name + "'s global permissions"
class ProjectPermission(PermissionModel): class ProjectPermission(PermissionModel):
project = models.ForeignKey(Project, related_name='permissions', editable=False) project = models.ForeignKey(Project, editable=False,
related_name='permissions')
create_issue = models.BooleanField(default=True) create_issue = models.BooleanField(default=True)
modify_issue = models.BooleanField(default=False) modify_issue = models.BooleanField(default=False)
@ -413,4 +442,5 @@ class ProjectPermission(PermissionModel):
delete_milestone = models.BooleanField(default=False) delete_milestone = models.BooleanField(default=False)
def __str__(self): def __str__(self):
return self.grantee_name + "'s permissions on " + self.project.name + " project" return self.grantee_name + "'s permissions on " \
+ self.project.name + " project"

View file

@ -4,7 +4,7 @@ from django.dispatch import receiver
from issue.models import Project, Label from issue.models import Project, Label
@receiver(post_save, sender=Project, dispatch_uid="Create default project labels.") @receiver(post_save, sender=Project, dispatch_uid="Default project labels.")
def create_default_project_labels(sender, **kwargs): def create_default_project_labels(sender, **kwargs):
if kwargs['created']: if kwargs['created']:
project = kwargs['instance'] project = kwargs['instance']

View file

@ -4,10 +4,12 @@ from django.utils.safestring import mark_safe
register = template.Library() register = template.Library()
@register.filter @register.filter
def boolean(value): def boolean(value):
if value: if value:
glyph = 'ok' glyph = 'ok'
else: else:
glyph = 'remove' glyph = 'remove'
return mark_safe('<span class="glyphicon glyphicon-' + glyph + '" style="vertical-align: middle;"></span>') return mark_safe('<span class="glyphicon glyphicon-'
+ glyph + '" style="vertical-align: middle;"></span>')

View file

@ -6,6 +6,7 @@ from django.utils.html import escape
register = template.Library() register = template.Library()
@register.simple_tag @register.simple_tag
def label_style(label): def label_style(label):
@ -18,12 +19,16 @@ def label_style(label):
return style.format(bg=label.color, fg=fg) return style.format(bg=label.color, fg=fg)
@register.simple_tag @register.simple_tag
def labeled(label): def labeled(label):
html = '<span class="label" style="{style} vertical-align: middle;">{name}</span>' html = '<span class="label" style="{style} ' \
'vertical-align: middle;">{name}</span>'
return mark_safe(html.format(style=label_style(label),
name=escape(label.name)))
return mark_safe(html.format(style=label_style(label),name=escape(label.name)))
@register.simple_tag @register.simple_tag
def same_label(label): def same_label(label):
@ -33,6 +38,7 @@ def same_label(label):
return mark_safe(url) return mark_safe(url)
@register.simple_tag @register.simple_tag
def same_milestone(milestone): def same_milestone(milestone):
@ -41,6 +47,7 @@ def same_milestone(milestone):
return mark_safe(url) return mark_safe(url)
@register.simple_tag(takes_context=True) @register.simple_tag(takes_context=True)
def same_author(context, author): def same_author(context, author):
@ -49,6 +56,7 @@ def same_author(context, author):
return mark_safe(url) return mark_safe(url)
@register.simple_tag @register.simple_tag
def vertical(string): def vertical(string):
return string.replace("", "\0").strip("\0").replace("\0", "<br />") return string.replace("", "\0").strip("\0").replace("\0", "<br />")

View file

@ -20,6 +20,7 @@ def profile(request):
return render(request, 'issue/profile.html', c) return render(request, 'issue/profile.html', c)
def global_permission_list(request): def global_permission_list(request):
permissions = GlobalPermission.objects.all() permissions = GlobalPermission.objects.all()
@ -30,6 +31,7 @@ def global_permission_list(request):
return render(request, 'issue/global_permission_list.html', c) return render(request, 'issue/global_permission_list.html', c)
def global_permission_edit(request, id=None): def global_permission_edit(request, id=None):
if id: if id:
@ -58,12 +60,13 @@ def global_permission_edit(request, id=None):
return render(request, 'issue/global_permission_edit.html', c) return render(request, 'issue/global_permission_edit.html', c)
def global_permission_toggle(request, id, perm): def global_permission_toggle(request, id, perm):
permission = get_object_or_404(GlobalPermission, id=id) permission = get_object_or_404(GlobalPermission, id=id)
# to be sure to dont modify other attribut with the following trick # to be sure to dont modify other attribut with the following trick
if not '-' in perm: if '-' not in perm:
raise Http404 raise Http404
perm = perm.replace('-', '_') perm = perm.replace('-', '_')
@ -76,6 +79,7 @@ def global_permission_toggle(request, id, perm):
return redirect('list-global-permission') return redirect('list-global-permission')
def global_permission_delete(request, id): def global_permission_delete(request, id):
permission = get_object_or_404(GlobalPermission, id=id) permission = get_object_or_404(GlobalPermission, id=id)
@ -86,6 +90,7 @@ def global_permission_delete(request, id):
return redirect('list-global-permission') return redirect('list-global-permission')
def project_permission_list(request, project): def project_permission_list(request, project):
permissions = ProjectPermission.objects.filter(project=project) permissions = ProjectPermission.objects.filter(project=project)
@ -97,10 +102,12 @@ def project_permission_list(request, project):
return render(request, 'issue/project_permission_list.html', c) return render(request, 'issue/project_permission_list.html', c)
def project_permission_edit(request, project, id=None): def project_permission_edit(request, project, id=None):
if id: if id:
permission = get_object_or_404(ProjectPermission, project=project, id=id) permission = get_object_or_404(ProjectPermission,
project=project, id=id)
else: else:
permission = None permission = None
@ -125,12 +132,13 @@ def project_permission_edit(request, project, id=None):
return render(request, 'issue/project_permission_edit.html', c) return render(request, 'issue/project_permission_edit.html', c)
def project_permission_toggle(request, project, id, perm): def project_permission_toggle(request, project, id, perm):
permission = get_object_or_404(ProjectPermission, project=project, id=id) permission = get_object_or_404(ProjectPermission, project=project, id=id)
# to be sure to dont modify other attribut with the following trick # to be sure to dont modify other attribut with the following trick
if not '-' in perm: if '-' not in perm:
raise Http404 raise Http404
perm = perm.replace('-', '_') perm = perm.replace('-', '_')
@ -143,6 +151,7 @@ def project_permission_toggle(request, project, id, perm):
return redirect('list-project-permission', project.name) return redirect('list-project-permission', project.name)
def project_permission_delete(request, project, id): def project_permission_delete(request, project, id):
permission = get_object_or_404(ProjectPermission, project=project, id=id) permission = get_object_or_404(ProjectPermission, project=project, id=id)
@ -153,6 +162,7 @@ def project_permission_delete(request, project, id):
return redirect('list-project-permission', project.name) return redirect('list-project-permission', project.name)
def project_list(request): def project_list(request):
if not request.projects.exists(): if not request.projects.exists():
@ -163,24 +173,20 @@ def project_list(request):
return render(request, 'issue/project_list.html') return render(request, 'issue/project_list.html')
def project_add(request): def project_add(request):
form = AddProjectForm(request.POST or None) form = AddProjectForm(request.POST or None)
if request.method == 'POST' and form.is_valid(): if request.method == 'POST' and form.is_valid():
if Project.objects \ name = form.cleaned_data['display_name']
.filter(display_name__iexact=form.cleaned_data['display_name']) \ if Project.objects.filter(display_name__iexact=name).exists():
.exists(): form._errors['display_name'] = ['There is already a project '
'with a similar name.']
form._errors['display_name'] = ['There is already a project with a similar name.']
else: else:
project = form.save() project = form.save()
messages.success(request, 'Project added successfully.') messages.success(request, 'Project added successfully.')
return redirect('list-issue', project.name) return redirect('list-issue', project.name)
c = { c = {
@ -189,24 +195,21 @@ def project_add(request):
return render(request, 'issue/project_add.html', c) return render(request, 'issue/project_add.html', c)
def project_edit(request, project): def project_edit(request, project):
form = EditProjectForm(request.POST or None, instance=project) form = EditProjectForm(request.POST or None, instance=project)
if request.method == 'POST' and form.is_valid(): if request.method == 'POST' and form.is_valid():
if Project.objects \ name = form.cleaned_data['display_name']
.filter(display_name__iexact=form.cleaned_data['display_name']) \ if Project.objects.filter(display_name__iexact=name) \
.exclude(pk=project.pk).exists(): .exclude(pk=project.pk).exists():
form._errors['display_name'] = ['There is already a project '
form._errors['display_name'] = ['There is already a project with a similar name.'] 'with a similar name.']
else: else:
project = form.save() project = form.save()
messages.success(request, 'Project modified successfully.') messages.success(request, 'Project modified successfully.')
return redirect('list-issue', project.name) return redirect('list-issue', project.name)
c = { c = {
@ -216,6 +219,7 @@ def project_edit(request, project):
return render(request, 'issue/project_edit.html', c) return render(request, 'issue/project_edit.html', c)
def project_delete(request, project): def project_delete(request, project):
project.delete() project.delete()
@ -224,6 +228,7 @@ def project_delete(request, project):
return redirect('list-project') return redirect('list-project')
def issue_list(request, project): def issue_list(request, project):
issues = project.issues issues = project.issues
@ -261,19 +266,22 @@ def issue_list(request, project):
if value == 'open': if value == 'open':
issues = issues.filter(closed=False) issues = issues.filter(closed=False)
is_open = ' active' is_open = ' active'
elif value =='close': elif value == 'close':
issues = issues.filter(closed=True) issues = issues.filter(closed=True)
is_close = ' active' is_close = ' active'
else: else:
messages.error(request, "The keyword 'is' must be followed by 'open' or 'close'.") messages.error(request, "The keyword 'is' must be followed "
"by 'open' or 'close'.")
issues = None issues = None
break break
elif key == 'label': elif key == 'label':
try: try:
label = Label.objects.get(project=project,name=value,deleted=False) label = Label.objects.get(project=project,
name=value, deleted=False)
except ObjectDoesNotExist: except ObjectDoesNotExist:
messages.error(request, "The label '%s' does not exist or has been deleted." %value) messages.error(request, "The label '%s' does not exist "
"or has been deleted." % value)
issues = None issues = None
break break
else: else:
@ -281,9 +289,10 @@ def issue_list(request, project):
elif key == 'milestone': elif key == 'milestone':
try: try:
milestone = Milestone.objects.get(project=project,name=value) milestone = Milestone.objects.get(project=project, name=value)
except ObjectDoesNotExist: except ObjectDoesNotExist:
messages.error(request, "The milestone '%s' does not exist." %value) messages.error(request, "The milestone '%s' does not exist."
% value)
issues = None issues = None
break break
else: else:
@ -293,12 +302,13 @@ def issue_list(request, project):
if User.objects.filter(username=value).exists(): if User.objects.filter(username=value).exists():
issues = issues.filter(author__username=value) issues = issues.filter(author__username=value)
else: else:
messages.error(request, "The user '%s' does not exist." %value) messages.error(request, "The user '%s' does not exist."
% value)
issues = None issues = None
break break
else: else:
messages.error(request, "Unknow '%s' filtering criterion." %key) messages.error(request, "Unknow '%s' filtering criterion." % key)
issues = None issues = None
break break
@ -323,6 +333,7 @@ def issue_list(request, project):
return render(request, 'issue/issue_list.html', c) return render(request, 'issue/issue_list.html', c)
def issue_edit(request, project, issue=None): def issue_edit(request, project, issue=None):
if issue: if issue:
@ -382,6 +393,7 @@ def issue_edit(request, project, issue=None):
return render(request, 'issue/issue_edit.html', c) return render(request, 'issue/issue_edit.html', c)
def issue(request, project, issue): def issue(request, project, issue):
issue = get_object_or_404(Issue, project=project, id=issue) issue = get_object_or_404(Issue, project=project, id=issue)
@ -404,13 +416,15 @@ def issue(request, project, issue):
return render(request, 'issue/issue.html', c) return render(request, 'issue/issue.html', c)
def issue_comment(request, project, issue, comment=None): def issue_comment(request, project, issue, comment=None):
issue = get_object_or_404(Issue, project=project, id=issue) issue = get_object_or_404(Issue, project=project, id=issue)
if comment: if comment:
event = get_object_or_404(Event, code=Event.COMMENT, issue=issue, id=comment) event = get_object_or_404(Event, code=Event.COMMENT,
init_data = { 'comment': event.additionnal_section } issue=issue, id=comment)
init_data = {'comment': event.additionnal_section}
else: else:
event = None event = None
init_data = None init_data = None
@ -448,6 +462,7 @@ def issue_comment(request, project, issue, comment=None):
return render(request, 'issue/issue_comment.html', c) return render(request, 'issue/issue_comment.html', c)
def issue_close(request, project, issue): def issue_close(request, project, issue):
issue = get_object_or_404(Issue, project=project, id=issue, closed=False) issue = get_object_or_404(Issue, project=project, id=issue, closed=False)
@ -461,6 +476,7 @@ def issue_close(request, project, issue):
return redirect('list-issue', project.name) return redirect('list-issue', project.name)
def issue_reopen(request, project, issue): def issue_reopen(request, project, issue):
issue = get_object_or_404(Issue, project=project, id=issue, closed=True) issue = get_object_or_404(Issue, project=project, id=issue, closed=True)
@ -474,6 +490,7 @@ def issue_reopen(request, project, issue):
return redirect('show-issue', project.name, issue.id) return redirect('show-issue', project.name, issue.id)
def issue_delete(request, project, issue): def issue_delete(request, project, issue):
issue = get_object_or_404(Issue, project=project, id=issue) issue = get_object_or_404(Issue, project=project, id=issue)
@ -484,6 +501,7 @@ def issue_delete(request, project, issue):
return redirect('list-issue', project.name) return redirect('list-issue', project.name)
def issue_add_label(request, project, issue, label): def issue_add_label(request, project, issue, label):
issue = get_object_or_404(Issue, project=project, id=issue) issue = get_object_or_404(Issue, project=project, id=issue)
@ -494,6 +512,7 @@ def issue_add_label(request, project, issue, label):
return redirect('show-issue', project.name, issue.id) return redirect('show-issue', project.name, issue.id)
def issue_remove_label(request, project, issue, label): def issue_remove_label(request, project, issue, label):
issue = get_object_or_404(Issue, project=project, id=issue) issue = get_object_or_404(Issue, project=project, id=issue)
@ -504,6 +523,7 @@ def issue_remove_label(request, project, issue, label):
return redirect('show-issue', project.name, issue.id) return redirect('show-issue', project.name, issue.id)
def issue_add_milestone(request, project, issue, milestone): def issue_add_milestone(request, project, issue, milestone):
issue = get_object_or_404(Issue, project=project, id=issue) issue = get_object_or_404(Issue, project=project, id=issue)
@ -514,6 +534,7 @@ def issue_add_milestone(request, project, issue, milestone):
return redirect('show-issue', project.name, issue.id) return redirect('show-issue', project.name, issue.id)
def issue_remove_milestone(request, project, issue, milestone): def issue_remove_milestone(request, project, issue, milestone):
issue = get_object_or_404(Issue, project=project, id=issue) issue = get_object_or_404(Issue, project=project, id=issue)
@ -524,6 +545,7 @@ def issue_remove_milestone(request, project, issue, milestone):
return redirect('show-issue', project.name, issue.id) return redirect('show-issue', project.name, issue.id)
def label_list(request, project): def label_list(request, project):
labels = project.labels.filter(deleted=False) labels = project.labels.filter(deleted=False)
@ -535,6 +557,7 @@ def label_list(request, project):
return render(request, 'issue/label_list.html', c) return render(request, 'issue/label_list.html', c)
def label_edit(request, project, id=None): def label_edit(request, project, id=None):
if id: if id:
@ -569,7 +592,8 @@ def label_edit(request, project, id=None):
issue = request.GET.get('issue') issue = request.GET.get('issue')
if issue: if issue:
return redirect('add-label-to-issue', project.name, issue, label.id) return redirect('add-label-to-issue', project.name,
issue, label.id)
return redirect('list-label', project.name) return redirect('list-label', project.name)
@ -581,6 +605,7 @@ def label_edit(request, project, id=None):
return render(request, 'issue/label_edit.html', c) return render(request, 'issue/label_edit.html', c)
def label_delete(request, project, id): def label_delete(request, project, id):
label = get_object_or_404(Label, project=project, id=id) label = get_object_or_404(Label, project=project, id=id)
@ -595,6 +620,7 @@ def label_delete(request, project, id):
return redirect('list-label', project.name) return redirect('list-label', project.name)
def milestone_list(request, project): def milestone_list(request, project):
show = request.GET.get('show', 'open') show = request.GET.get('show', 'open')
@ -617,6 +643,7 @@ def milestone_list(request, project):
return render(request, 'issue/milestone_list.html', c) return render(request, 'issue/milestone_list.html', c)
def milestone_edit(request, project, name=None): def milestone_edit(request, project, name=None):
if name: if name:
@ -636,7 +663,8 @@ def milestone_edit(request, project, name=None):
if similar.exists(): if similar.exists():
form._errors['name'] = ['There is already a milestone with this name.'] form._errors['name'] = ['There is already a milestone '
'with this name.']
else: else:
@ -644,8 +672,11 @@ def milestone_edit(request, project, name=None):
if name != form.cleaned_data['name']: if name != form.cleaned_data['name']:
author = User.objects.get(username=request.user.username) author = User.objects.get(username=request.user.username)
for issue in milestone.issues.all(): for issue in milestone.issues.all():
event = Event(issue=issue, author=author, code=Event.CHANGE_MILESTONE, event = Event(issue=issue, author=author,
args={'old_milestone': name, 'new_milestone': form.cleaned_data['name']}) code=Event.CHANGE_MILESTONE, args={
'old_milestone': name,
'new_milestone': form.cleaned_data['name']
})
event.save() event.save()
form.save() form.save()
messages.success(request, 'Milestone modified successfully.') messages.success(request, 'Milestone modified successfully.')
@ -657,7 +688,8 @@ def milestone_edit(request, project, name=None):
issue = request.GET.get('issue') issue = request.GET.get('issue')
if issue: if issue:
return redirect('add-milestone-to-issue', project.name, issue, milestone.name) return redirect('add-milestone-to-issue', project.name, issue,
milestone.name)
return redirect('list-milestone', project.name) return redirect('list-milestone', project.name)
@ -669,6 +701,7 @@ def milestone_edit(request, project, name=None):
return render(request, 'issue/milestone_edit.html', c) return render(request, 'issue/milestone_edit.html', c)
def milestone_close(request, project, name): def milestone_close(request, project, name):
milestone = get_object_or_404(Milestone, project=project, name=name) milestone = get_object_or_404(Milestone, project=project, name=name)
@ -678,6 +711,7 @@ def milestone_close(request, project, name):
return redirect('list-milestone', project.name) return redirect('list-milestone', project.name)
def milestone_reopen(request, project, name): def milestone_reopen(request, project, name):
milestone = get_object_or_404(Milestone, project=project, name=name) milestone = get_object_or_404(Milestone, project=project, name=name)
@ -687,6 +721,7 @@ def milestone_reopen(request, project, name):
return redirect('list-milestone', project.name) return redirect('list-milestone', project.name)
def milestone_delete(request, project, name): def milestone_delete(request, project, name):
milestone = get_object_or_404(Milestone, project=project, name=name) milestone = get_object_or_404(Milestone, project=project, name=name)

View file

@ -55,7 +55,9 @@ MIDDLEWARE_CLASSES = (
'django.contrib.auth.middleware.AuthenticationMiddleware', 'django.contrib.auth.middleware.AuthenticationMiddleware',
) )
if VERSION >= (1, 7): if VERSION >= (1, 7):
MIDDLEWARE_CLASSES += ('django.contrib.auth.middleware.SessionAuthenticationMiddleware',) MIDDLEWARE_CLASSES += (
'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
)
MIDDLEWARE_CLASSES += ( MIDDLEWARE_CLASSES += (
'django.contrib.messages.middleware.MessageMiddleware', 'django.contrib.messages.middleware.MessageMiddleware',
'django.middleware.clickjacking.XFrameOptionsMiddleware', 'django.middleware.clickjacking.XFrameOptionsMiddleware',
@ -98,7 +100,7 @@ STATIC_URL = '/static/'
LOGIN_URL = '/login' LOGIN_URL = '/login'
LOGIN_REDIRECT_URL='/' LOGIN_REDIRECT_URL = '/'
CRISPY_TEMPLATE_PACK = 'bootstrap3' CRISPY_TEMPLATE_PACK = 'bootstrap3'

View file

@ -3,6 +3,6 @@ from django.contrib import admin
urlpatterns = patterns('', urlpatterns = patterns('',
url(r'^admin/', include(admin.site.urls)), url(r'^admin/', include(admin.site.urls)),
url(r'^markdown/', include( 'django_markdown.urls')), url(r'^markdown/', include('django_markdown.urls')),
url(r'^', include('issue.urls')), url(r'^', include('issue.urls')),
) )

3
tox.ini Normal file
View file

@ -0,0 +1,3 @@
[pep8]
exclude=env,issue/migrations,issue/urls.py
ignore=E128