inpt/ponytracker
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: '-' not allowed in var name

Browse source
This commit is contained in:
Élie Bouttier 2014-12-10 21:33:35 +01:00
parent 3d097abadb
commit 11c5d24d64
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tracker/views.py
View file

@ -424,9 +424,7 @@ def issue_comment_edit(request, project, issue, comment=None):
issue = get_object_or_404(Issue, project=project, id=issue) issue = get_object_or_404(Issue, project=project, id=issue)
redirect = 'to-issue'
change_state = False change_state = False
if 'change-state' in request.POST: if 'change-state' in request.POST:
if not request.user.has_perm('manage_issue', project): if not request.user.has_perm('manage_issue', project):
raise PermissionDenied() raise PermissionDenied()
@ -448,8 +446,10 @@ def issue_comment_edit(request, project, issue, comment=None):
if request.method == 'POST' and form.is_valid(): if request.method == 'POST' and form.is_valid():
redirect_to = 'issue'
comment = form.cleaned_data['comment'] comment = form.cleaned_data['comment']
# modification of an existent comment
if event: if event:
if event.additionnal_section != comment: if event.additionnal_section != comment:
@ -459,6 +459,7 @@ def issue_comment_edit(request, project, issue, comment=None):
else: else:
messages.info(request, 'Comment not modified.') messages.info(request, 'Comment not modified.')
# creation of a new comment
else: else:
event = Event(issue=issue, author=request.user, event = Event(issue=issue, author=request.user,
@ -474,7 +475,7 @@ def issue_comment_edit(request, project, issue, comment=None):
event.save() event.save()
notify_close_issue(event) notify_close_issue(event)
messages.success(request, 'Comment added successfully and issue closed.') messages.success(request, 'Comment added successfully and issue closed.')
redirect = 'to-list' redirect_to = 'list'
else: else:
event = Event(issue=issue, author=request.user, code=Event.REOPEN) event = Event(issue=issue, author=request.user, code=Event.REOPEN)
event.save() event.save()
@ -483,7 +484,7 @@ def issue_comment_edit(request, project, issue, comment=None):
else: else:
messages.success(request, 'Comment added successfully.') messages.success(request, 'Comment added successfully.')
if redirect == 'to-issue': if redirect_to == 'issue':
return redirect('show-issue', project.name, issue.id) return redirect('show-issue', project.name, issue.id)
else: else:
return redirect('list-issue', project.name) return redirect('list-issue', project.name)