milestone open/close: 404 if action make no sens

This commit is contained in:
Élie Bouttier 2014-09-03 00:13:26 -07:00
parent 92076e3d9e
commit 028834ce57

View file

@ -645,9 +645,9 @@ def label_delete(request, project, id):
return redirect('list-label', project.name) return redirect('list-label', project.name)
########## ##############
# Labels # # Milestones #
########## ##############
def milestone_list(request, project): def milestone_list(request, project):
@ -731,7 +731,7 @@ def milestone_edit(request, project, name=None):
@project_perm_required('manage_tags') @project_perm_required('manage_tags')
def milestone_close(request, project, name): def milestone_close(request, project, name):
milestone = get_object_or_404(Milestone, project=project, name=name) milestone = get_object_or_404(Milestone, closed=False, project=project, name=name)
milestone.closed = True milestone.closed = True
milestone.save() milestone.save()
@ -742,7 +742,7 @@ def milestone_close(request, project, name):
@project_perm_required('manage_tags') @project_perm_required('manage_tags')
def milestone_reopen(request, project, name): def milestone_reopen(request, project, name):
milestone = get_object_or_404(Milestone, project=project, name=name) milestone = get_object_or_404(Milestone, closed=True, project=project, name=name)
milestone.closed = False milestone.closed = False
milestone.save() milestone.save()