From 2738e6712ca8d2d9daea9235f49517a678ff140c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89lie=20Bouttier?= Date: Fri, 8 Aug 2014 19:30:28 -0700 Subject: [PATCH] prevent useless events like same label change --- issue/models.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/issue/models.py b/issue/models.py index 8d6ce17..50178a2 100644 --- a/issue/models.py +++ b/issue/models.py @@ -172,6 +172,8 @@ class Issue(models.Model): description = property(getdesc, setdesc, deldesc) def add_label(self, author, label, commit=True): + if self.labels.filter(pk=label.pk).exists(): + return self.labels.add(label) if commit: self.save() @@ -188,6 +190,8 @@ class Issue(models.Model): event.save() def add_milestone(self, author, milestone, commit=True): + if self.milestone == milestone: + return if self.milestone: event = Event(issue=self, author=author, code=Event.CHANGE_MILESTONE, args={'old_milestone': self.milestone.name,